Closed ueman closed 1 week ago
👑
Is there anything left for me to do?
Is there anything left for me to do?
We let the author merge after approval but it is not mentioned in the Contributing guideline. AFter the refactor, we will need to add more rules.
I don't have the rights to merge the PR, or maybe it's due to the failing "check for tests" job?
Description
This place was missing the types, so you could actually run into an issue where you pass incompatible types.
You could actually test this by enabling the strong language analyzer options:
But I don't know whether that's something you want to do. I've briefly tried to enable them, and it shows a lot more issues. That's also why I didn't enable them as a test for these changes.
Related Issues
none
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
While technically this is a breaking API change (you could pass an unrelated type), it's not a change in behavior (only passing correct types would make the code work)