woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
511 stars 64 forks source link

Add missing types #332

Closed ueman closed 1 week ago

ueman commented 1 month ago

Description

This place was missing the types, so you could actually run into an issue where you pass incompatible types.

You could actually test this by enabling the strong language analyzer options:

analyzer:
  language:
    strict-raw-types: true
    strict-inference: true
    strict-casts: true

But I don't know whether that's something you want to do. I've briefly tried to enable them, and it shows a lot more issues. That's also why I didn't enable them as a test for these changes.

Related Issues

none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

While technically this is a breaking API change (you could pass an unrelated type), it's not a change in behavior (only passing correct types would make the code work)

ulusoyca commented 1 month ago

👑

ueman commented 1 month ago

Is there anything left for me to do?

ulusoyca commented 1 month ago

Is there anything left for me to do?

We let the author merge after approval but it is not mentioned in the Contributing guideline. AFter the refactor, we will need to add more rules.

ueman commented 1 month ago

I don't have the rights to merge the PR, or maybe it's due to the failing "check for tests" job?