search

woltapp / wolt_modal_sheet

This package provides a responsive modal with multiple pages, motion animation for page transitions, and scrollable content within each page.
MIT License
511 stars 64 forks source link

Bump min Flutter SDK version to 3.16.0 #343

Closed ulusoyca closed 3 days ago

ulusoyca commented 3 days ago

Description

Bumps the min Flutter SDK version to 3.16.0

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

github-actions[bot] commented 3 days ago

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

TahaTesser commented 3 days ago

Taking a look at failures.

github-actions[bot] commented 3 days ago

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

TahaTesser commented 3 days ago

@ulusoyca I fixed avoid-suspicious-super-overrides issues. There are tons more of these avoid-suspicious-super-overrides issues, which may require lot of refactoring. Perhaps disable this rule?

TahaTesser commented 3 days ago

Link to the rule https://dcm.dev/docs/rules/common/avoid-suspicious-super-overrides/

ulusoyca commented 3 days ago

@TahaTesser let's remove this rule. How about the failing tests?

github-actions[bot] commented 3 days ago

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

github-actions[bot] commented 3 days ago

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.