wolverine2k / andtweet

Automatically exported from code.google.com/p/andtweet
Apache License 2.0
0 stars 0 forks source link

AndTweet does not properly remember position #40

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Start application OR switch between Mentions and Friends activities

What is the expected output? What do you see instead?

I expect that the position will be saved correctly, instead it goes to the
last tweet on the page. I've also noticed some discrepancies when going to
a tweet and going back to the list. Sometimes it positions itself with the
tweet just below the bottom of the screen, sometimes above.

Original issue reported on code.google.com by torgny.b...@gmail.com on 25 May 2010 at 1:28

GoogleCodeExporter commented 8 years ago

Original comment by torgny.b...@gmail.com on 25 May 2010 at 1:30

GoogleCodeExporter commented 8 years ago
I just wanted to confirm this issue on my G1.

Original comment by matthias...@googlemail.com on 26 May 2010 at 6:38

GoogleCodeExporter commented 8 years ago
When I studied the code I've also noticed that current implementation 
of "remembering last position" is far from complete, but it works for the most 
needed scenario:
1. User clicks on the tweet and sees details of this tweet (what Torny calls 
"going 
to a tweet")
2. User clicks on the link in the tweet and sees linked page in the Internet 
Browser.
3. User goes back to the tweet.
4. User goes back to the list of tweets. AndTweet positions the list to the 
same (or 
close...) position as on step 1.

What is not implemented yet:
1. Every "view" ("Friends", "Mentions", Search results...) should have it's own 
set 
of persistent attributes (including position...)
2. By default new (just created) "view" shows only ONE page of tweets (20 
tweets), 
so if the remembered tweet is not on the first page AndTweet positions on the 
last 
tweet of this page. In order to set the list on the remembered tweet, we should 
load 
all pages up to the page where that tweet is...

Original comment by yvo...@gmail.com on 26 May 2010 at 7:16

GoogleCodeExporter commented 8 years ago
I've got what was described by Torgny: "Sometimes it positions itself with the
tweet just below the bottom of the screen":
- AndTweet (in fact, Adroid libraries) position last tweet on a page as if 
there is 
no "What happens?" textbox.
So it looks like the problem lies in the layout. I think we better change 
layout so 
that "What happens?" textbox is not visible all the time, but rather opens only 
after User taps some "What happens?" button, located at the top of the 
screen... 
(something like in the official Twitter client)

Original comment by yvo...@gmail.com on 3 Jun 2010 at 12:39

GoogleCodeExporter commented 8 years ago
In the "Revision fa270880a5" I've worked on this task and greatly improved this 
"positioning" feature
plus "pagination" is more intelligent now (it's even in search results now!)

TODO: Remember both top visible row and row that is some rows below (the last 
to retrieve from DB )

Original comment by yvo...@gmail.com on 26 Jul 2010 at 6:18

GoogleCodeExporter commented 8 years ago
Fixed in "Revision 554a7f11ea". In this version I've changed which tweet is 
being stored:  now Id of the Last Visible item is being stored (not the first 
one!)

Original comment by yvo...@gmail.com on 26 Jul 2010 at 4:37