Project Feedback for dating

wolyniec / MI-449-SS17-741-js-collect-and-display-information-kPt9Fl

0 stars 0 forks source link

Project Feedback for dating #1

Open wolyniec opened 7 years ago

wolyniec commented 7 years ago

Build a dating profile generator

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

[x] Use this base HTML (feel free to change it) to build a simple app that generates the HTML for a dating profile in this format, using information collected from the user
[x] Show a preview of the dating profile with rendered HTML (e.g. hella charming should appear as hella charming)
[x] Also show the raw, generated HTML inside the <pre><code></code></pre> elements (e.g. hella charming should appear as hella charming)
[x] Both the preview and raw HTML should update live as the user enters their information
[x] All JavaScript is in a separate .js file
[x] There are no linting errors in your JavaScript (this will also be expected for all future projects)

stuartpearman commented 7 years ago

Hey Ivan, can you push to GtiHub pages?

wolyniec commented 7 years ago

I tried earlier but I got an email later that it "failed", let me give it another shot really quick!

On Tue, May 2, 2017 at 8:15 PM, Stuart Pearman notifications@github.com wrote:

Hey Ivan, can you push to GtiHub pages?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wolyniec/MI-449-SS17-741-js-collect-and-display-information-kPt9Fl/issues/1#issuecomment-298796177, or mute the thread https://github.com/notifications/unsubscribe-auth/ATSvKp0Igu-UeR1NTcrwcKLwrdSgh8XRks5r18c9gaJpZM4NOvXp .

wolyniec commented 7 years ago

Should be up now!

On Tue, May 2, 2017 at 8:22 PM, Ivan Wolyniec mushypal@gmail.com wrote:

I tried earlier but I got an email later that it "failed", let me give it another shot really quick!

On Tue, May 2, 2017 at 8:15 PM, Stuart Pearman notifications@github.com wrote:

Hey Ivan, can you push to GtiHub pages?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wolyniec/MI-449-SS17-741-js-collect-and-display-information-kPt9Fl/issues/1#issuecomment-298796177, or mute the thread https://github.com/notifications/unsubscribe-auth/ATSvKp0Igu-UeR1NTcrwcKLwrdSgh8XRks5r18c9gaJpZM4NOvXp .

stuartpearman commented 7 years ago

Wow, this really looks great Ivan. Your code is very readable, and I like the jokes sprinkled in 😁 :shipit: