search

wombats-writing-code / fbw-components

Fly-by-Wire components for building user interfaces
http://fbw.mit.edu
MIT License
0 stars 1 forks source link

Recommended change to module deletion behavior #26

Closed chadlieberman closed 7 years ago

chadlieberman commented 7 years ago

I propose that the Xoces tool be changed so that deletion of a module removes it but does not affect its child outcomes. These outcomes can be shared across modules and deleting one module can affect other modules in the current implementation. I just made this mistake on a minor scale, and I can restore things pretty easily, but it may lead to much bigger problems later on if we don't change it.

coleshaw commented 7 years ago

Changed and deployed, I tested on dev and it seemed to be fine -- let me know if you run into any issues.

luwen-huang commented 7 years ago

why would an outcome appear in more than one module? can you give me an example of when that's the case?

On Mon, Aug 29, 2016 at 5:50 PM, cjshawMIT notifications@github.com wrote:

Closed #26 https://github.com/wombats-writing-code/fbw-components/issues/26.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wombats-writing-code/fbw-components/issues/26#event-770874549, or mute the thread https://github.com/notifications/unsubscribe-auth/ACsQkv2e5RCdrCrx82bsD_hve-sfvqf_ks5qkv_DgaJpZM4JveJB .

chadlieberman commented 7 years ago

I think there are many instances when this could happen, and that should be enough to warrant the change. For example, when we reorganize our outcomes into semantic modules from the Unit X based organization. Had we deleted the Unit X modules, I think all of the outcomes would have disappeared... Once faculty members start using Xoces, anything could happen =)