search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Updated README #102

Closed lili2311 closed 8 years ago

lili2311 commented 8 years ago

@womenhackfornonprofits/whfnp

What are the changes included in this PR?

Updated README with the new instructions to watch for fron tend changes

EChesters commented 8 years ago

The above line where you;ve changed needs to be updated as well: In order for Jekyll to watch and compile all the changes to html run jekyll serve in the src directory

This is where I hit the issue.

lili2311 commented 8 years ago

@EChesters the command does both jekyll serve and sass watch for you, please see here: https://github.com/womenhackfornonprofits/whfnp/blob/dev/Gruntfile.js#L203 and the concurrent serve command: https://github.com/womenhackfornonprofits/whfnp/blob/dev/Gruntfile.js#L184 compiles both Jekyll templates and sass.

So running grunt or grunt default is all you need (both do the same thing)

EChesters commented 8 years ago

I understand it does both, but the line I highlighted does not work. It's now redundant and needs to be removed.

To run, we should not use jekyll serve like the README file still states after your change.

lili2311 commented 8 years ago

😫 i see it now, thanks! pushing update

lili2311 commented 8 years ago

Updated

EChesters commented 8 years ago

Approved 👍