search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Newsletter section missing from some pages #11

Closed krissy closed 8 years ago

krissy commented 8 years ago

From browsing, the Newsletter section has been omitted on the following pages:

krissy commented 8 years ago

Happy to add but confirming if this is on purpose or accidentally omitted first

lili2311 commented 8 years ago

on purpose due to the alternating colours, can be added in but last section should be white on every page so add this in the css?

tanyapowell commented 8 years ago

@krissy and @lili2311 can this issue be closed?

EChesters commented 8 years ago

In terms of UX I think both of these pages would benefit from having the newsletter section on there.

@lili2311 When you make a design decision can you clear it up before going ahead and omitting sections :)

I've done the templating for these pages so later this week I'll add them in a re-push. I'll change this to in progress and keep it open for now.

EChesters commented 8 years ago

Will be fixed by: https://github.com/womenhackfornonprofits/whfnp/pull/109 and https://github.com/womenhackfornonprofits/whfnp/pull/104

EChesters commented 8 years ago

This has been fixed by the 2 previous PRs mentioned, which have been merged.