search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Issue #66 - Form makeover #113

Closed EChesters closed 8 years ago

EChesters commented 8 years ago

@womenhackfornonprofits/whfnp

Issue-77

EChesters commented 8 years ago

This is actually Issue #113 and not Issue 66 I saw the wrong issue when I was typing the commit message and I can't change it.

EChesters commented 8 years ago

Volunteer contact form:

screen shot 2016-06-19 at 21 18 42

NP contact form:

screen shot 2016-06-19 at 21 17 59

Contact form:

screen shot 2016-06-19 at 20 03 28
EChesters commented 8 years ago

In terms of the names fields I have some questions:

  1. Is there any reason why we separate them?
  2. Will there be any back end issue not making surname a required field - not everyone in this world has a surname.

Can we remove the surname field and combine it with first name, or just remove the required attribute?

Nandhini31 commented 8 years ago

@EChesters :+1: Yes fine with all the new forms. happy to have just one name field.

tanyapowell commented 8 years ago

This is just my opinion, but it looks a little weird only have the name field with the little icon on the right hand side of the input box.

image

Could you add one to email too?

tanyapowell commented 8 years ago

@Nandhini31 were you giving the 👍 on the whole pull request or just answering the question?

EChesters commented 8 years ago

@tanyapowell The icon in the field next to name is my LastPass auto fill plugin. That isn't something I've done and it'll go away on other people's screens.

@lili2311 The selector wasn't that specific since help text when used on a site is used everywhere. Bootstrap also has this selector and I was overriding that.

I'm just about to change the name fields to combine them and use @tanyapowell's way of wrapping the input inside label. Will the names being combined into one cause any issues when submitting and the way we expect the data?

lili2311 commented 8 years ago

.larger-button is being used in the projects page, please check it wont affect it

EChesters commented 8 years ago

I tried @tanyapowell's suggestion but it broke the styling. This has been sidelined for now by Tanya.

Top of volunteers form now just says name. Will this break submitting the form?

screen shot 2016-06-23 at 23 20 39
EChesters commented 8 years ago

.col-sm-9

screen shot 2016-06-24 at 19 53 05

.col-md-7

screen shot 2016-06-24 at 19 53 15

.col-xs-12

screen shot 2016-06-24 at 19 53 19

Please see the above for .col-lg-3!!

lili2311 commented 8 years ago

.col-sm-9 and .col-sm-7 both look a little too wide in my opinion, perhaps smaller width?

tanyapowell commented 8 years ago

@EChesters can you send over your wireframes for any forms? If the width in your screengrab matches (or is near enough to the wireframe) then it'll be fine 😄

EChesters commented 8 years ago

The prototype is here: http://echesters.co.uk/WHFNP-Website/ but I did give up on them half way through and didn't get round to doing the forms. On the wireframes these also weren't done because I hadn't done the contact pages.

tanyapowell commented 8 years ago

Just been through the code and it's all good with me 👍🏿

On Wed, 6 Jul 2016 at 14:40 Elizabeth Chesters notifications@github.com wrote:

The prototype is here: http://echesters.co.uk/WHFNP-Website/ but I did give up on them half way through and didn't get round to doing the forms. On the wireframes these also weren't done because I hadn't done the contact pages.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/womenhackfornonprofits/whfnp/pull/113#issuecomment-230773973, or mute the thread https://github.com/notifications/unsubscribe/AKlONUycthCrhgHU5IB3JhztbyG3RrdVks5qS7A3gaJpZM4I5On6 .

Tanya Powell about.me/tanyapowell https://about.me/tanyapowell?promo=email_sig