Closed VAO11 closed 8 years ago
I think we need to move the form the very top so that it is not something you need to scroll for, could you add it to the section right under the "What to expect" so that the form is on white background and is right underneath where we explain how it works? And for now leave Start Your Journey Here section as we still want to keep that page.
Hey @VAO11 😄 - just wondering why so many existing files are coming up as new files in your PR? E.g. the gruntfile.js
and README.md
Also, @VAO11 your placeholders in the image above don't match the ones in the file. Could you paste in an updated image. Ta
@tanyapowell I only changed the non-profits.html file. Not sure how I managed to the other files pulled in to be honest.
@lili2311 I can move the form higher up th e page np.
I can either cancel this pull request and delete the branch to start again or I will need some guidance to clean up the branch only include the changes I made.
I this the other file changes were done by Lili to get the workspace working from c9.io.
What would you suggest?
Sure thing we can tidy up, it looks like perhaps a jekyll serve command run in a wrong directory and created a_site
file in the root of the project. So on your branch go to the root folder for whfnp
and delete the _site
folder completely. Do a git status
and git add
, then git commit
and git push
. This should remove this unwanted folder
Closing Branch as too many additional changes. Creating a new Branch.
@womenhackfornonprofits/whfnp
Linked Jira/Github Issue Ticket
58
What are the changes included in this PR?
If the changes are visual, provide a screenshot.
@lili2311 Hi Lili, can you please review my change for issue 58 and let me know if you are happy for this to be merged