search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

remove col-2 col-3 and added bootstrap grid template #145

Closed herecomesjaycee closed 8 years ago

herecomesjaycee commented 8 years ago

@womenhackfornonprofits/whfnp

Linked Jira/Github Issue Ticket - issue 136 https://github.com/womenhackfornonprofits/whfnp/issues/136

What are the changes included in this PR?

I removed the col-2 and col-3 and put in bootstrap grid template.

If the changes are visual, provide a screenshot.

lili2311 commented 8 years ago

Could you please do a screenshot for desktop and mobile so it is easier to say if the layout os good to go or needs some tweaking before we merge? Otherwise 👍

herecomesjaycee commented 8 years ago
screen shot 2016-09-05 at 22 28 33 screen shot 2016-09-05 at 22 28 38 screen shot 2016-09-05 at 22 28 40

There is an issue with the latest Gruntfile.js where I can't run Grunt >> SyntaxError: Unexpected token <<

lili2311 commented 8 years ago

Thanks! Strange you don't have any images? Is grunt task running?

So the speech bubbles look too big on desktop I think they need to be maybe a col-4 or even 3 with an offset so that they both stay in the center of the page with their edges if that makes sense?

herecomesjaycee commented 8 years ago

There is an issue with the latest Gruntfile.js where I can't run Grunt ">> SyntaxError: Unexpected token <<" and it is the latest version of the file on Github. Shall make the change on the boostrap :)

lili2311 commented 8 years ago

Sounds like there was a merge conflict maybe if you post your gruntfile we can have you push a fix for it

herecomesjaycee commented 8 years ago

Oh dear! How may I post my gruntfile?

herecomesjaycee commented 8 years ago

screen shot 2016-09-18 at 14 55 17 - Mobile view screen shot 2016-09-18 at 14 54 56 - Desktop view