search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Feature/hamburger #156

Closed lili2311 closed 8 years ago

lili2311 commented 8 years ago

@womenhackfornonprofits/whfnp

Linked Jira/Github Issue Ticket

https://github.com/womenhackfornonprofits/whfnp/issues/132

What are the changes included in this PR?

Responsive mobile and desktop menu

If the changes are visual, provide a screenshot.

You can test it on dev: http://devwomenhackfornonprofits.s3-us-west-2.amazonaws.com/contact.html

VAO11 commented 8 years ago

Hey Lili, the menu looks great. Only have one question. Did you want the hamburger menu to move down the page on its own without the navbar?

This happens on my Samsung.

lili2311 commented 8 years ago

Hiya! Yes it is sticky on purpose for easy menu access. If you think the whole nav sticky might look better can certainly do that.

VAO11 commented 8 years ago

I think at very the least the hamburger should have a white background behind it so it can be clearly seen as you scroll down the page. I just chose white as it is the navbar colour.