search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Fixes/final tweaks #172

Closed lili2311 closed 7 years ago

lili2311 commented 7 years ago

@womenhackfornonprofits/whfnp

Linked Jira/Github Issue Ticket

What are the changes included in this PR?

If the changes are visual, provide a screenshot.

VAO11 commented 7 years ago

Hi @lili2311, all the fixes look great. The only thing I noticed other than what Eli spotted is the text on the About Us page: image

The text is vertically aligned to the top in IE. It appears as centred in Chrome and Firefox. Other than that this looks good to deploy.

herecomesjaycee commented 7 years ago

Tested in Edge, the link headers works the same as Chrome.

image image

lili2311 commented 7 years ago

ty! working on the IE bug :)

VAO11 commented 7 years ago

Happy to merge and raise separate issue for the IE11 banner issue.