Labels added to contact form and placeholder font changed

[tanyapowell]

@EChesters @lili2311

Issue #21

Contact Form

• Labels added to Contact Form
• Padding between some labels and input fields corrected
• Drop Shadow removed from submit button (See Issue #22)

  Volunteers Sign Up form

• Drop Shadow removed from submit button (See Issue #22)
• Padding between some labels and input fields corrected

[lili2311]

could you add normalize as a partial and import it?

[lili2311]

If we have labels should the placeholder be actual examples of what we are after?

[tanyapowell]

I think the placeholders need changing on both the contact form and volunteer form, but would like @EChesters UX opinion on it

[tanyapowell]

Also, could we add normalize as a dependency?

[EChesters]

Placeholders need to be an example of the format and data that we're expecting. Labels look good now. On the volunteers sign up why are we just asking for surname and not full name or both(first/last)? Also not entirely convinced why we should be asking for LinkedIn, but re-looking at that form which fields are required?

Placeholder examples would be: Full name: Jon Snow

Email: jon.snow@example.com

Twitter: @IKnowNothing

[tanyapowell]

LinkedIn is a client requirement. Will modify the placeholders to be examples 😊

[EChesters]

Are all the fields required? Because if so we will need to way of telling the users. (and not by using a star) Why do clients need LinkedIn profiles?

👍

[tanyapowell]

@lili2311 are all the fields required? If yes, I'll create another PR for them

Placeholder changes

Contact us

Volunteer sign up

[lili2311]

As long as the normalize dependency doesn't re-download when someone new wants to clone project, ideally we don't want the look of the site to change just because there is a newer version of normalize.

The forms already have required set some basic required fields, this has good overall support, this prompts the user to fill the field in if they have not done so already (try filling the form out on site): http://caniuse.com/#search=required Contact: all required but Phone

Volunteer & Non-Profits Contact: we could do with confirming what else but name and email is a required field.

[lili2311]

There is also this form: https://s3-eu-west-1.amazonaws.com/whfnp.co.uk/non-profits-contact.html, will you be amending this too in this PR?

[tanyapowell]

Normalize: you can specify the version of the dependency in the package.json

Non-profits currently looks like the below image, so will just modify the placeholder text:

[lili2311]

Okies add the non profits contact form here and then :+1:

[tanyapowell]

Issue #30 also fixed

[lili2311]

Please also post mobile screenshots?

[tanyapowell]

Non-Profits

Contact Us

Volunteer

[lili2311]

:+1: after merge conflict is resolved.