search

womenhackfornonprofits / whfnp

Women Hack for Non-Profits Website Overhaul
18 stars 7 forks source link

Resolved bootstrap conflict, added fashrevwall project. #92

Closed lili2311 closed 8 years ago

lili2311 commented 8 years ago

@womenhackfornonprofits/whfnp

Issue-68

What are the changes included in this PR?

EChesters commented 8 years ago

We should avoid putting images in the CSS, because the images are content that needs to be added via HTML. I think there is an issue to replace all images (other than banner) like this already.

Title in projects.html shouldn't have quote marks around it.

Could you also remove the notes from the commit title?

lili2311 commented 8 years ago

Yep there is a separate issue open for that, so can change all at once on the next PR.

Will fix the other comments and push an update.

lili2311 commented 8 years ago

@tanyapowell and @EChesters can I merge this and do the templating in the next PR this PR is older than the templates.

tanyapowell commented 8 years ago

@lili2311 could you have a quick look at the conflicts first? You won't be able to merge with them in

lili2311 commented 8 years ago

done!

lili2311 commented 8 years ago

please OK :) @tanyapowell or @EChesters and I will merge

tanyapowell commented 8 years ago

👍