search

womenintech-chennai / womenintech-website

4 stars 18 forks source link

gatsby develop command working now #31

Open sauravj20 opened 5 years ago

sauravj20 commented 5 years ago
  1. [x] closes issue #xxxx
  2. [ ] gatsby develop runs without errors
  3. [ ] gatsby build runs without errors
  4. [ ] Learning entry in Learning.md

2 and 3 Not applicable for non code changes

gatsby develop command working properly now. Migrating to version 2 worked for me

bhavaniravi commented 5 years ago

@sauravj20 Thank you for taking time to contribute.

A couple of changes before we merge it

  1. Can you mark the issue number in 1st checkbox - if there is no issue raise one and close it?
  2. There is a conflict in package-lock can you fix it and merge one more time
  3. Checkbox 2 & 3 still applies for this PR since you changed the dependencies. Please ensure its working before pushing
bhavaniravi commented 5 years ago

Looks good. Please pull master and resolve conflicts and let's merge

bhavaniravi commented 5 years ago

@sauravj20 can you pull master and fix the merge conflicts