Cutting by about 75% the time for loading mff records.

wonambi-python / wonambi

Package to analyze EEG, ECoG and other electrophysiology formats. It allows for visualization of the results and for a GUI that can be used to score sleep stages.

https://wonambi-python.github.io/

BSD 3-Clause "New" or "Revised" License

82 stars 19 forks source link

Cutting by about 75% the time for loading mff records. #2

Closed christian-oreilly closed 7 years ago

christian-oreilly commented 7 years ago

I previously proposed a patch using io.open instead of open. This is responsible for cutting execution time by 50%. The additional changes here also cuts processing time by about another 50%. I left in comment the code required if you want to check that this still gives the exact same results as previously. Worked perfectly on my system... and much more manageable to work with ~30 GO files...

gpiantoni commented 7 years ago

Thanks a lot for the patch! It's been merged. Sorry for taking so long to merge it. Very happy for your contributions!

christian-oreilly commented 7 years ago

No problem. My pleasure.

Best,

Christian

2017-10-13 9:45 GMT+02:00 Gio Piantoni notifications@github.com:

Thanks a lot for the patch! It's been merged. Sorry for taking so long to merge it. Very happy for your contributions!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wonambi-python/wonambi/pull/2#issuecomment-336376800, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqHmpOVnmmtnJ6s1NlTq5h1WRGC7DwVks5srxUzgaJpZM4Pa3T6 .