search

wonday / react-native-pdf

A <Pdf /> component for react-native
MIT License
1.58k stars 544 forks source link

feat: add Fabric support #700

Closed WoLewicki closed 1 year ago

WoLewicki commented 1 year ago

PR adding New Architecture support to the library :tada:

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on projects@swmansion.com

samjayhk commented 1 year ago

Hello @WoLewicki , just want to thanks for your development work. I have tried to using master branch under Fabric mode, and it's all going well. But may I know if you have planned release current master branch as alpha version? Thanks!

WoLewicki commented 1 year ago

@samjayhk thanks! I am not a maintainer of this library, so this question is rather to @wonday.

Bort-777 commented 1 year ago

Hello, @wonday .

Do you have any plans to release a new version of the library? I was thinking it might be a good idea to prepare a pull request for the minor version bump, let me know if there's anything we can do to help.

Thanks for your time!

Sowed commented 1 year ago

Hello @WoLewicki , just want to thanks for your development work. I have tried to using master branch under Fabric mode, and it's all going well. But may I know if you have planned release current master branch as alpha version? Thanks!

@WoLewicki, same sentiment here. Thank you for this PR. Had an app breaking on me with the PDF when I migrated to RN 0.71.7, installing master directly following this PR fixes it for me. So far so good.

Installed via

# terminal
yarn add https://github.com/wonday/react-native-pdf.git#master
# package.json
"react-native-pdf": "https://github.com/wonday/react-native-pdf.git#master",