wonday / react-native-pdf

A <Pdf /> component for react-native
MIT License
1.58k stars 540 forks source link

[Android] Update to use native `PdfRenderer` #706

Open ecexplorer opened 1 year ago

ecexplorer commented 1 year ago

Apologies if this is the wrong place to put this on the roadmap, please feel free to redirect, but helpful to open an issue for discussion and tracking.

Since React Native v0.64, the minSDK supported by Android is 21. This is also the SDK which introduced PdfRenderer, Android's "native" way to render PDFs for display without the need for an external library (like AndroidPdfViewer). This library should update /android to use the native SDK for PDF rendering.

Here's a helpful article talking about the upsides of PdfRenderer: https://proandroiddev.com/rendering-pdfs-on-android-the-easy-way-c05635b2c3a8.
It's also worth pointing out that as AndroidPdfViewer ages, it's not receiving updates (last commit Aug 2019). And has had an open call for maintainers since before that time: https://github.com/barteksc/AndroidPdfViewer#looking-for-new-maintainer.

I'd absolutely love to tackle this, but it'll be months until I find the time 😞 . I'll happily review/guide others that have the bandwidth in the meantime πŸ˜„

What react-native version are you using?
v0.64 or higher

What react-native-pdf version are you using?
v6.6.2

What platform does your issue occur on? (android/ios/both)
Android

Describe your issue as precisely as possible : 1) Steps to reproduce the issue or to explain in which case you get the issue 2) Interesting logs

Join a screenshot or video of the problem on the simulator or device?

Show us the code you are using?

BraveEvidence commented 1 year ago

This could help https://www.youtube.com/watch?v=Afrd4z1aMNM https://www.youtube.com/watch?v=AHo--82qk2o