search

wonday / react-native-pdf

A <Pdf /> component for react-native
MIT License
1.58k stars 540 forks source link

fix typo in RNPDFPdfViewManagerInterface interface causing android build crash #745

Closed MuhmdRaouf closed 1 year ago

MuhmdRaouf commented 1 year ago

fix typo which causing android build to crash with the following error message

> Task :react-native-pdf:compileReleaseJavaWithJavac FAILED
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:29: error: PdfManager is not abstract and does not override abstract method showsVerticalScrollIndicator(PdfView,boolean) in RNPDFPdfViewManagerInterface
public class PdfManager extends SimpleViewManager<PdfView> implements RNPDFPdfViewManagerInterface<PdfView> {
       ^
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:97: error: method does not override or implement a method from a supertype
    @Override
    ^
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:102: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors