wonday / react-native-pdf

A <Pdf /> component for react-native
MIT License
1.57k stars 532 forks source link

Update AndroidPdfViewer library #821

Closed zacharee closed 3 months ago

zacharee commented 4 months ago

Talbot Gooday's AndroidPdfViewer library hasn't received updates in years and never updated the underlying native PDFium library.

PdfiumAndroidKt is a successor to PdfiumAndroid, rewritten in Kotlin, and with updated native libraries. It's also being actively maintained.

This PR changes the AndroidPdfViewer dependency to my fork, which depends on PdfiumAndroidKt instead of PdfiumAndroid. I also added a direct dependency here to PdfiumAndroidKt so that it can be updated alongside PdfiumAndroidKt without needing to modify AndroidPdfViewer first.

I also did a little cleanup in the Gradle config and in PdfView.

My fork of AndroidPdfViewer comes with similar caveats to Talbot Gooday's in that I don't plan on maintaining it. However, I will be monitoring pull requests for features and bugfixes, and since PdfiumAndroidKt is doing most of the heavy lifting, AndroidPdfViewer shouldn't need many updates.