search

wonday / react-native-pdf

A <Pdf /> component for react-native
MIT License
1.59k stars 546 forks source link

iOS New Architecture/Fabric build error: no member named 'enableDoubleTapZoom' #831

Open timbocole opened 5 months ago

timbocole commented 5 months ago

What react-native version are you using? RN0.74.0

What react-native-pdf version are you using? v6.7.5

What platform does your issue occur on? (android/ios/both) ios

Describe your issue as precisely as possible : Building with New Architecture enabled/Fabric results in compilation error.

app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:139:42: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
    if (_enableDoubleTapZoom != newProps.enableDoubleTapZoom) {
                                ~~~~~~~~ ^
app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:140:41: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
        _enableDoubleTapZoom = newProps.enableDoubleTapZoom;
keuvy commented 5 months ago

I was having the same problem

@timbocole fix solved for me

oidoug commented 4 months ago

Here's a patch, apply it with patch-package:

react-native-pdf+6.7.5.patch

timbocole commented 4 months ago

Resolved by my PR #832 however will leave this issue open until it is included in a published release

hahtml commented 4 months ago

Cool, the patch works on my end!