search

wonder-sk / qgis-first-aid-plugin

The must-have tool for QGIS Python plugin developers
GNU General Public License v2.0
45 stars 15 forks source link

'ResourceWarning: unclosed file' from sourceview.py #46

Closed pers-ephone closed 5 months ago

pers-ephone commented 8 months ago

\firstaid\sourceview.py:43: ResourceWarning: unclosed file self.setText(open(filename).read())

is there any reason to not use

with open(filename) as file:
       self.setText(file.read())

?

nyalldawson commented 8 months ago

Absolutely no good reason not to 😝 !

can you file a pull request?

(There's quite a lot of older python 2 style code which could potentially be cleaned up in this plugin, if you spot others then all modernization requests are welcome!)