wongkj12 / pe

0 stars 0 forks source link

No error message when I input a long age to edit #5

Open wongkj12 opened 4 months ago

wongkj12 commented 4 months ago

When i enter "edit S1234567B ag\12345678901", nothing happens but there is no error message saying why this fails. It seems that 11 characters is the implicit limit, however a 10-character age still works (see below).

image.png

An error message could be helpful to inform users that the age value has a limit.

soc-pe-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Attempting to edit the age of a person to an unrealistic value fails silently

image.png

As seen in the screenshot, after attempting edit S1234567A ag\55555555555555555555555555555555555, the app does not return an error message nor edits the person (the command output shown in the screenshot is from a previous command).


[original: nus-cs2103-AY2324S2/pe-interim#675] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Screenshot 2024-04-20 at 9.29.06 PM.png

We personally do not think that users will purposely input such a large age and since our app still work fine according to the guidelines here^, it will not be considered a bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]