wonglkd / mathflowy

Chrom{e,ium} extension to provide MathJax rendering for Workflowy
https://chrome.google.com/webstore/detail/mathflowy/enkondafgdaafikjlehpnjebnknfgfle
9 stars 5 forks source link

New update broke compatibility with Firefox via Chrome Store Foxified #4

Closed wonglkd closed 8 years ago

wonglkd commented 8 years ago

@wonglkd Thank you for the fix. Just one thing … the old version could be used in Firefox as well, via the extension "Chrome Store Foxified". Since the update, this doesn't work anymore (installing the extension has no effect whatsoever).

I'm aware that Mathflowy is a Chrome extension and that it is not your responsibility to maintain compatibility with another browser via a third-party extension – but if you could do anything about this, it would be great. (Actually, I think it was not the fix of this issue that broke Firefox support but the additional settings that were added in the subsequent commit.)

ClaudiusL commented 8 years ago

It seems like commit dfa3f0376f64950ce391df28420aa9bc5443dc55 broke the compatibility with Firefox via Chrome Store Foxified. However, it is possible to use commit 81c87f05863b2a30cdd50eef5f2563ffe92f37a4 in Firefox (though without the comfort of Chrome Store Foxified):

Happy Mathflowy-ing!

wonglkd commented 8 years ago

Thanks for the detailed steps! The problem appears to be caused by Firefox not supporting the sync storage area (as documented in https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities).

Thankfully the fix appears to be quite easy. I've pushed a new commit 326ce69, which falls back to the local storage area. I loaded it in Firefox and it appears to work. (Steps: download a zip of the repository, unzip it and load the manifest file in the directory via Load Temporary Add-on in about:debugging). If you could have a go at it, that would be great. I'll update the Chrome store version shortly.

Thanks for bringing this up!

ClaudiusL commented 8 years ago

Yep, this works, even the custom delimiters can be used in Firefox.

wonglkd commented 8 years ago

Thanks! Closing this issue since it's been fixed.