search

wongnai / kube-slack

Kubernetes Slack Monitoring
MIT License
323 stars 59 forks source link

add PodCompleted to blacklistReason & minor fix #16

Closed jstriebel closed 6 years ago

jstriebel commented 6 years ago

This adds PodCompleted to the blacklistReason. Pods created by jobs get this as their status after successful completion.

Via this I found an edge case: If the text for a slack notification is undefined or empty, slack.send returns undefined (which is the case for Job pods). This results in some hard to trace errors. To avoid this case, I added a general default message, if none is given.

Thanks for considering this PR.

whs commented 6 years ago

Thanks for your PR. I'll publish a release tomorrow.

whs commented 6 years ago

v3.1.1 is published on Docker Hub :tada: