search

wongsm7 / pe

0 stars 0 forks source link

Another undo bug #7

Open wongsm7 opened 4 years ago

wongsm7 commented 4 years ago

After typing statsbasic:

image.png

image.png

And then undo:

image.png

Does not go back to the previous state.

nus-pe-bot commented 4 years ago

Team's Response

Regarding undoability of commands, the implementation was designed to allow users to undo mistakes while modifying their data. We have implemented in a way in which is only undoes commands which manipulate model data (e.g. addexpense, deleteexpense) while commands which do not manipulate data are non-undoable (e.g. help, view, etc). Statistics-related commands are inherently not modifying the model, it merely represents the model data in another way.

Furthermore, as stated in the User Guide, the Command Summary section indicates which commands are undoable by appending ('undoable') beside the command word. In the statistics-related commands, statsbasic, among all other commands in it, does not have this tag, which indicates that the command is non-undoable.

And so, the situation described in the report is intended, that is unable to undo statsbasic, which we could have better documented in the User Guide and Developer Guide.

As this is intended behaviour, I am rejecting this bug.

Changing bug type to DocumentationBug:

This is the intended behaviour. Even in intelliJ for example, pressing CTRL-Z or CMD-Z to undo an action does not undo changing between files and only undoes actions which modifies text. We designed the feature with this kind of behaviour in mind. Even though it has been documented in the Command Summary section on the User Guide, the team understands that it could have been more documented clearly.

Downgrading severity to Low:

Again, as this is an intended process, this issues does not affect normal intended operations of the product. At most, it can cause very slight inconvenience for end-users.

More info on the severity level, taken from the CS2103T website, as follows:

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product.

severity.High : A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users. This issue only causes minor inconvenience at most, it does not make the product unusable.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]

:question: Issue type

Team chose [type.DocumentationBug]. Originally [type.FunctionalityBug].

Reason for disagreement: [replace this with your reason]