search

wongwh2002 / pe

0 stars 0 forks source link

Improper validation of NRIC #4

Open wongwh2002 opened 1 week ago

wongwh2002 commented 1 week ago

image.png command: add n/person s/o father v/21-10-2024 15:38 ic/q1234567a

NRIC should only start with certain alphabets but i am able to use any alphabets for NRIC

UG says its restricted to "S" and "T" as it is for Singapore's context but Singapore also has foreigners which NRIC starts with "G", many Singapore's users will be excluded from this app

soc-pe-bot commented 1 week ago

Team's Response

Hi Tester, Thank you for your Description of Issue and Feedback.

Indeed, we missed on that for foreigners, prefix for FIN(Not Nric) is "F", "G", or "M" .

However, we already mentioned specifically in our UG that for this iteration of BookBob, the intended use cases and scope are for Singapore context.

image.png

Indeed, we missed out on checking for the first letter to be strictly "S" or "T", but we would think that this is a low severity issue which only happens in rare cases (when the doctor has a typo for the patient's NRIC, which the doctor can use the edit command to edit the patient's NRIC to a correct one).

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]