woniesong92 / skeema.io

Skeema.io
0 stars 0 forks source link

Project Edit Misc #5

Open sweetticket opened 9 years ago

sweetticket commented 9 years ago

(Usability)

woniesong92 commented 9 years ago

Wow I realized I didn't clear these at all. But there were some updates. @sweetticket

  1. Bootstrap branch is merged into master. All conflicts are resolved and I wrote Utils.toast() function using Bootstrap alert.
  2. Sidenav is styled and the bugs associated with deleting buttons are fixed.
  3. Trials and Blocks can be rearranged using jQuery-UI's sortable API. Backend is Work in Progress.
  4. You can delete blocks now.
  5. Image can be uploaded.
  6. Some miscellaneous bugs are fixed.

Some things that should be done:

  1. We have to replace the current Bootstrap package with another one. Look at the above thread. We also have to use Bootstrap grid system.
  2. Let's not use color class names anymore. I thought about it more and we should definitely not use them because we should modify elements' colors in .less files exclusively. Create colors.less file and import it from other less files.
  3. Back button and breadcrumbs to navigate to previous frame or trial.
  4. Should be able to copy elements by doing cmd + c or ctrl + c.
  5. We must not set DOM elements' id attribute to their Mongo object counterparts' ids. I started this pattern but it's not a right thing to do LOL Let's find a way to fix it. This is Michael's answer to the email that I sent:
Simplest thing is if <div class="person"> is a template and then the Person object is the template's data.
Then in your event handlers you can just say "this.data" or "this.person".
If you need to keep that explicitly in your DOM then I suspect you are doing something wrong?

But jsPlumb elements are not in Meteor template forms, so I am not sure how to do it in that case.

sweetticket commented 9 years ago

But jsPlumb elements are not in Meteor template forms, so I am not sure how to do it in that case.

The frames are in meteor template forms, so I think that's covered. As for paths, I think it's okay to leave it as it is since it will be visible only to the experimenter (not the participants). The important part is hiding the ids from the participants when the experiment is published.

sweetticket commented 9 years ago
sweetticket commented 9 years ago

@woniesong92
* Notes on keypress paths *

  1. Should we increase the max-length of the input field in the path modal? Example, the input "rgba" would allow "r" or "g" or "b" or "a" to proceed to the next frame. Or should we force them to create separate paths for each individual key? (Howon: separate paths because in most cases they wouldn't have to create more than four paths between two frames)
  2. We should have a drop down next to the input field with the options "IS" or "IS NOT".
woniesong92 commented 9 years ago

@sweetticket FYI: The problem with indices was that we didn't assign right index values when copying and deleting :sweat_smile: Good job clearing all the tasks!!! Let's hunt more bugs!