search

wonks / Talk_Rehearsal_Feedback

1 stars 0 forks source link

2017 ICFP - Praveen Narayanan #4

Closed frenchy64 closed 6 years ago

frenchy64 commented 7 years ago

Leave feedback for the talk in comments on this issue.

david-christiansen commented 7 years ago

Putting text on a slide and then hiding it again is frustrating for me as an audience member. (this is the table of similarities)

david-christiansen commented 7 years ago

The association between the labels and the variables in y=an+b is not so clear just from the graphics. In particular, "per-iteration cost" looks closer to a than to n.

rrnewton commented 7 years ago

Rather than showing the example (running time, linear regression), and then saying the approach is actually more general (sounds defensive), perhaps better to say it is general first and then transition via "here's a particular example".

david-christiansen commented 7 years ago

Is the bendy left arrow on "Write generative model" the normal Haskell left arrow, or is it some other notation?

samth commented 7 years ago

Can you write the input/output so that they look more similar?

david-christiansen commented 7 years ago

Why is constrainValue written as a left triangle? Given that it's punctuation, shouldn't it be infix in Haskelly notation, or surrounded in parens? The current one is a bit slow to visually parse.

david-christiansen commented 7 years ago

The slide with "posterior distribution" at the bottom of the slide is about where my brain got lost in the code. I lost track of what "factor" means, as well as the history of the code examples shown.

cderici commented 7 years ago

Can you find a smaller example? It's a little hard to keep track of all the different stages of the transformation.

samth commented 7 years ago

The whole first half of the talk doesn't really make clear what you're adding.

david-christiansen commented 7 years ago

I'm still not sure what light blue boxed code means.

david-christiansen commented 7 years ago

is plate a binding form? If so, why does it use . instead of -> the way lambda does on your slides?