search

wonsikin / react-native-barcode-builder

Component for generating barcode in react native app
Other
175 stars 116 forks source link

Handling of invalid barcode #5

Closed tiaanduplessis closed 7 years ago

tiaanduplessis commented 7 years ago

Thank you for the module 👍 .

Would you consider if instead of throwing an error for invalid barcode, the component provides an onError property to handle it? I'm using the module in App where the user inputs the barcode value and instead of adding custom validation it would make sense to use the existing validation provided by jsBarcode within the module. Would be happy to do the PR.

wonsikin commented 7 years ago

@tiaanduplessis I'm looking forward your PR.

tiaanduplessis commented 7 years ago

8