wonsikin / react-native-barcode-builder

Component for generating barcode in react native app
Other
175 stars 116 forks source link

Changing library from ART to react-native-svg #50

Closed cdesch closed 4 years ago

cdesch commented 4 years ago

This change removes ART and adds react-native-svg as the drawing library for producing the barcode. This change is to support the deprecation of ART from the ReactNative libraries. The react community ART library is not linked in Expo v36 projects. SVG is the preferred method. This change is linked to issue #49 https://github.com/wonsikin/react-native-barcode-builder/issues/49

There are no tests for this changes. Changes will need to be made to the readme first.

wonsikin commented 4 years ago

Thanks for your contribution. But we decide to use @react-native-community/art

formaldehydeson commented 4 years ago

thanks for this, only way I could get it working on iOS using Expo

donni106 commented 4 years ago

thanks for this, only way I could get it working on iOS using Expo

same for me. copied @cdesch code to my project and use that instead of the package, which results in: https://github.com/wonsikin/react-native-barcode-builder/issues/59

JonathanMai commented 4 years ago

same here, not using expo and having the same issue. Thanks @cdesch for the fix! :)

namti commented 8 months ago

Switching to https://www.npmjs.com/package/expo-barcode-generator solves this issue.