wooclap / moodle-mod_wooclap

Moodle plugin for Wooclap (https://www.wooclap.com/).
2 stars 5 forks source link

Lesson import questions function and Wooclap activity #16

Closed forobliot closed 1 year ago

forobliot commented 1 year ago

Hello, I am contacting you in order to report an issue about the use of Wooclap activities and Lesson Activities in the same Moodle course. We noticed that the function "Lesson mod import questions" of a Lesson acitvity does not work if there is a wooclap activity in the same course. The issue seems to be related to the wooclap lib.php which includes the question/format.php file. Is it essential for the Wooclap Moodle plugin?

step to reproduce the problem:

Wanbonnet commented 1 year ago

Hello @forobliot,

Thank you for reporting this issue. We'll have a look into it, and get back to you when we have an update to provide.

manzan46 commented 1 year ago

@forobliot Sorry for the delay on this one, we think we found the issue and it's indeed link to this similar fix done on Moodle side https://github.com/moodle/moodle/blob/556208417deb47ccea80d00849aae6fb4d47f228/question/format/xml/format.php#L29 where for some reason two file format.php and the mod/lesson.format.phpare declaring the same function.

We will release a new version of the plugin after having done more test and keep you posted, 🤞🏻 before end of week

manzan46 commented 1 year ago

👋🏻 @forobliot

We fixed the issue, could you please ask update to the last Moodle Wooclap plugin which is the 2023030900 and then retry.

Let us know if all good and sorry for the inconvenience.

forobliot commented 1 year ago

I have just updated the plugin and now I am able to import questions into lesson-type activities, thanks for fixing the plugin's code!

manzan46 commented 1 year ago

@forobliot thanks for quick feedback and reporting the issue in first place. 🙏🏻