wooclap / moodle-mod_wooclap

Moodle plugin for Wooclap (https://www.wooclap.com/).
2 stars 5 forks source link

Wrong function name #20

Open jrm-unamur opened 1 year ago

jrm-unamur commented 1 year ago

Hi there, According to the gradebook api (https://docs.moodle.org/dev/Gradebook_API) there is a mistake in a function name wooclap_update_grade should be wooclap_update_grades

Regards

jaume77 commented 11 months ago

Hi, I see that there is a call to that function in the report_wooclap_v3.php file:

// Find user from username.
$userdb = $DB->get_record('user', ['username' => $username], 'id', MUST_EXIST);

$gradestatus = wooclap_update_grade($wooclapinstance, $userdb->id, $score, $completion_param);

$completion = new completion_info($course);
$completion->update_state($cm, $completion_param, $userdb->id);

Thanks Jaume R.

lucaboesch commented 11 months ago

https://github.com/wooclap/moodle-mod_wooclap/pull/21 would fix this but it hasn't been merged yet, @jaume77 .

jaume77 commented 11 months ago

Ok, so #21 also modifies the call in the file report_wooclap_v3.php

Thanks! Jaume R.

lucaboesch commented 8 months ago

Good catch @jaume77.

It now does. Pinging @throskam-wooclap. This should be merged.

Best, Luca