Closed marco-verbeek closed 9 months ago
PHP should only contain PHP code and should not include HTML. Separated in different files.
Some PHPUnit tests for the Privacy API and the data privacy plugin are failing because of a call to debugging().
Fixed the incorrect wrapping when declaring a class.
There were some variables that were unused.
The operator “and” was being used instead of “&&”.
Some files were not checking the capabilities of the current user.
The use of the parameter type ‘PARAM_RAW_TRIMMED’ is not allowed. Changed it.
The name of the functions used in lib.php did not contain the name of the plugin as a prefix.
We were using the (now deprecated) print_error function.
Fixed many linting issues.
Do not use PHP and HTML in the same file
PHP should only contain PHP code and should not include HTML. Separated in different files.
PHPUnit tests for Privacy failed
Some PHPUnit tests for the Privacy API and the data privacy plugin are failing because of a call to debugging().
Incorrect wrapping on class declaration
Fixed the incorrect wrapping when declaring a class.
Unused variables
There were some variables that were unused.
Use of and instead of &&
The operator “and” was being used instead of “&&”.
Any logged in user can call methods on some files
Some files were not checking the capabilities of the current user.
Parameter type not allowed
The use of the parameter type ‘PARAM_RAW_TRIMMED’ is not allowed. Changed it.
The Function names on the lib file should be unique
The name of the functions used in lib.php did not contain the name of the plugin as a prefix.
Update deprecated function to throw exceptions
We were using the (now deprecated) print_error function.
Linting
Fixed many linting issues.