woocommerce / FlexSlider

An awesome, fully responsive jQuery slider plugin
http://www.woocommerce.com/flexslider/
GNU General Public License v2.0
4.92k stars 1.69k forks source link

add swiping flag property during swipes (#1682) and fix broken resize/etc handler (#1665) #1683

Closed RwwL closed 6 years ago

RwwL commented 6 years ago

The reason for adding a swiping property during swipes handled by the touch option is so that swipes can be ignored and not handled as touches/intent to navigate when using the asNav option. Fixes #1682.

I know you've already got a handle on #1665 but I just thought I'd mention it here because we'd made that fix in parallel in our own repo.

RwwL commented 6 years ago

Found a critical bug in the commit that adds itemMargin to the slider.visible calculation (https://github.com/woocommerce/FlexSlider/pull/1683/commits/1482f390f9c22991d7732aed69117cc852db4b80), so closing this out and creating a new one.