search

woocommerce / FlexSlider

An awesome, fully responsive jQuery slider plugin
http://www.woocommerce.com/flexslider/
GNU General Public License v2.0
4.92k stars 1.69k forks source link

Initial height of first slide incorrect using smoothHeight #1710

Closed jnpwebdeveloper closed 1 month ago

jnpwebdeveloper commented 6 years ago

Using a basic slider setup containing slides with varying heights the first slide is too tall/not correctly sized when using smoothHeight.

My settings:

                animation: "slide",
                customDirectionNav: jQuery(".dlp-testimonials-navigation a", $slider),
                smoothHeight: true,
                slideshow: false

I have several testimonials. In this instance the first slide is very short with a subsequent slide being very long. On initial load the first slide with the short text has a lot of white space beneath it. The issue seems that smoothHeight works between transitions but does not correct the overall height on initial load.

[Update] - I believe this was addressed for the fade animation type but not the slide version as per this Pull request: https://github.com/woocommerce/FlexSlider/pull/602/commits/4e54832f7d7cf67abb4ec8da718bacc4246502cb

jnpwebdeveloper commented 6 years ago

Create a PR with a fix that worked for me.