search

woocommerce / action-scheduler-custom-tables

This plugin is no longer needed. The custom table code is now part of Action Scheduler version 3.0 and newer. If you're using the latest Action Scheduler, you have the most performant schema available.
https://actionscheduler.org
14 stars 2 forks source link

update plugins_loaded hooks to action_scheduler_pre_init #53

Closed rrennick closed 5 years ago

rrennick commented 5 years ago

Fixes #50

This PR updates the 2 uses of plugins_loaded to action_scheduler_pre_init. This will ensure that AS 2.2.0 or later is active.

thenbrent commented 5 years ago

@rrennick the code looks fine to me, but a lot of unit tests are failing now with Travis so there's something wrong with it (not sure what). Could you please review those failures?

rrennick commented 5 years ago

@thenbrent I tracked this back to the dependency check always failing when hooked into plugins_loaded. Due to the negative logic, the tests had been running. When moved to action_scheduler_pre_init, the dependency check was passing.

Since we want this plugin to self disable this PR would be better merged against an AS merge branch rather than master.

thenbrent commented 5 years ago

Since we want this plugin to self disable this PR would be better merged against an AS merge branch rather than master.

I've added SHA: b8f7ac20b to make sure the repo is tested against version_3_0_0 now, and reverted the commit to change it to 3.1.0. All looks good now. 👍