woocommerce / action-scheduler

A scalable, traceable job queue for background processing large queues of tasks in WordPress. Specifically designed for distribution in WordPress plugins (and themes) - no server access required.
https://actionscheduler.org
GNU General Public License v3.0
641 stars 117 forks source link

Remove grunt-phpcs? #944

Open coreymckrill opened 1 year ago

coreymckrill commented 1 year ago

It looks like we're using this grunt-phpcs package as a shortcut for running phpcs. However, the package hasn't been updated in 8 years, and it is supposed to be run with a very old version of Node. It seems like we could remove this package and just run phpcs via a composer script or something.

Here's the error I get when I run npm i:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'grunt-phpcs@0.4.0',
npm WARN EBADENGINE   required: { node: '0.10.x' },
npm WARN EBADENGINE   current: { node: 'v16.19.1', npm: '8.19.4' }
npm WARN EBADENGINE }
vedanshujain commented 1 year ago

Seems we can get rid of most node js thingies here, we only need the package json fine to make it work with wc release tool. Marking as a enhancement request. Let us know if you want to sent a PR.