Closed WillBrubaker closed 3 years ago
Tested and confirmed this issue on master
branch, and confirmed that this is not broken in 2.4.1
tag. So it looks like we introduced this as part of the JS tidy up - good catch! Adding critical label since this is an introduced issue.
Also updated the testing instructions in description.
I'll look at getting a fix for this. Hopefully we can track down the old JS code - I'm not familiar with this feature.
@WillBrubaker (or anyone affected) - can you add some info about how this Reset Facebook metadata
fits into product sync workflow? E.g. when you need to reset metadata and why, what's the wider goal there. While I'm here I want to make sure I understand how this fits in to the bigger picture :)
The forum thread is what brought me here. Perhaps the OP can provide some insight.
We do have 4014280-zen and if the product sync workflow hadn't failed to begin with, we probably wouldn't be where we are, but we need this same functionality there to try and reset that product so we can try again to sync it up.
Thanks - so this is being used in a "reset / clear / nuke it so I can start again" flow.
Note - we still have the function so it maybe just an enqueuing assets issue. Stay tuned!
I could replicate this as well on 2.5.0
Another report in 4022847-zen
Client reports that version 2.5.0 also has a problem with deleting products via metabox. So I guess it's the build process for this metabox.js which is not working as planned.
The fix for this has now been released - update stores to 2.5.1+ and the metabox should be working correctly again.
🔎 Isolate the bug
✍️ Describe the bug
As reported in this support thread: https://wordpress.org/support/topic/reset-meta-data-broken-since-last-update
When clicking the "Reset Facebook metadata" the metadata is not reset and in fact, nothing happens except for a JavaScript error i.e.
Uncaught ReferenceError: fb_reset_product is not defined
🚶♀️ Steps to reproduce
Products
and edit a product.Facebook
metabox and clickReset Facebook metadata
.Uncaught ReferenceError: fb_reset_product is not defined
✔️ Expected behavior
That the metadata is reset as advertised by the anchor text.
Pre 2.5 this would show a modal confirm prompt, and then the metabox would show
This product is not yet synced to Facebook.
state.🗃 Logs