woocommerce / facebook-for-woocommerce

A first-party extension plugin built for WooCommerce. Development is managed by Ventures.
https://woocommerce.com/products/facebook/
GNU General Public License v2.0
211 stars 140 forks source link

fix undefined SETTING_ENABLE_DEBUG_MODE #2779

Closed rawdreeg closed 3 months ago

rawdreeg commented 3 months ago

Changes proposed in this Pull Request:

This is something that escaped our attention in this PR: https://github.com/woocommerce/facebook-for-woocommerce/pull/2754. The constant SETTING_ENABLE_DEBUG_MODE should not be called from self. but from WC_Facebookcommerce_Integration.

Closes #2778.

Screenshots:

Detailed test instructions:

Upgrade the plugin from version 1, and no errors should occur.

Changelog entry

Fix - Update failing due to undefined constant error in Lifecycle

lynnjat7 commented 3 months ago

Just noting that the original reporting customer on this tried the code fix already (@rawdreeg provided it to me on Slack) and it worked, so looks like clear sailing for this fix. 8503847-zen

rawdreeg commented 3 months ago

I'll merge this one without a review

ecgan commented 3 months ago

Closes https://github.com/woocommerce/facebook-for-woocommerce/pull/2278.

@rawdreeg , I believe you have a typo above. I have edited your PR description to "Closes https://github.com/woocommerce/facebook-for-woocommerce/issues/2778."

rawdreeg commented 3 months ago

Thanks, @ecgan

layoutd commented 3 months ago

Thanks for identifying and cleaning this up, @rawdreeg