search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
44 stars 21 forks source link

Release 2.7.2 #2426

Closed github-actions[bot] closed 2 months ago

github-actions[bot] commented 2 months ago

Checklist

  1. [x] Check if the version, base, and target branches are as you desire.
  2. [x] Make sure you have woorelease installed and set up.
  3. [x] Go to your local repo clone, and check out this PR to be able to commit any potential adjustments. 
    git fetch origin release/2.7.2
git checkout release/2.7.2
  4. [x] Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. [x] If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released. :warning: Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. [x] :exclamation: If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. [x] Simulate the release locally 
    woorelease simulate --product_version=2.7.2  --wc_tested=9.0 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.7.2

    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"

  8. [x] The changelog is correct. Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label. You can also edit the changelog manually in the woorelease release step later.
  9. [x] Automated tests are passing.
  10. [x] Test the package
    1. [x] Install the /tmp/google-listings-and-ads.zip file on a test site
    2. [x] Confirm it activates without warnings/errors and is showing the right versions
    3. [x] Run a few basic smoke tests

Next steps

  1. [x] Do the final release 
    woorelease release --product_version=2.7.2  --wc_tested=9.0  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.7.2

    When prompted for changelog entries, double-check and apply any changes if needed.

  2. [x] Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.7.2, generate GitHub release notes, and paste them as a comment here.
  3. [x] Merge this PR after the new release is successfully created and the version tags are updated.
  4. [x] Merge trunk to develop (PR), if applicable for this repo.
  5. [ ] Update documentation
    • [x] Publish any new required docs
    • [ ] Update triggers/rules/actions listing pages
  6. [ ] Mark related ideas complete on the feature requests page.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 76.24309% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.4%. Comparing base (1b7b1d5) to head (43af1f8).

:exclamation: Current head 43af1f8 differs from pull request most recent head 62cc942

Please upload reports for the commit 62cc942 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## trunk #2426 +/- ## ========================================== - Coverage 64.2% 63.4% -0.7% ========================================== Files 755 321 -434 Lines 21538 5027 -16511 Branches 1157 1218 +61 ========================================== - Hits 13818 3188 -10630 + Misses 7559 1672 -5887 - Partials 161 167 +6 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.4% <76.2%> (+0.6%)` | :arrow_up: | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/components/account-card/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Faccount-card%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvYWNjb3VudC1jYXJkL2luZGV4Lmpz) | `96.8% <ø> (ø)` | | | [...ts/google-ads-account-card/claim-account-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fclaim-account-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvY2xhaW0tYWNjb3VudC1idXR0b24uanM=) | `100.0% <100.0%> (ø)` | | | [...nts/google-ads-account-card/claim-account/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fclaim-account%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvY2xhaW0tYWNjb3VudC9pbmRleC5qcw==) | `100.0% <100.0%> (ø)` | | | [...nents/google-ads-account-card/connect-ads/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fconnect-ads%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvY29ubmVjdC1hZHMvaW5kZXguanM=) | `96.0% <100.0%> (ø)` | | | [...-account-card/connected-google-ads-account-card.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fconnected-google-ads-account-card.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvY29ubmVjdGVkLWdvb2dsZS1hZHMtYWNjb3VudC1jYXJkLmpz) | `0.0% <ø> (ø)` | | | [...s/google-ads-account-card/create-account-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fcreate-account-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvY3JlYXRlLWFjY291bnQtYnV0dG9uLmpz) | `11.1% <100.0%> (ø)` | | | [...omponents/google-ads-account-card/disabled-card.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fdisabled-card.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvZGlzYWJsZWQtY2FyZC5qcw==) | `100.0% <100.0%> (ø)` | | | [...ents/google-ads-account-card/disconnect-account.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fdisconnect-account.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvZGlzY29ubmVjdC1hY2NvdW50Lmpz) | `100.0% <100.0%> (ø)` | | | [...nents/google-ads-account-card/terms-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fgoogle-ads-account-card%2Fterms-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZ29vZ2xlLWFkcy1hY2NvdW50LWNhcmQvdGVybXMtbW9kYWwvaW5kZXguanM=) | `100.0% <100.0%> (ø)` | | | [...onents/paid-ads/billing-card/billing-setup-card.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fbilling-card%2Fbilling-setup-card.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYmlsbGluZy1jYXJkL2JpbGxpbmctc2V0dXAtY2FyZC5qcw==) | `92.9% <100.0%> (+63.4%)` | :arrow_up: | | ... and [18 more](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | | ... and [469 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2426/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
mikkamp commented 2 months ago

PHP Unit tests are currently failing because the script to fetch the latest WooCommerce versions, is fetching non existent tagged versions. WC 9.0 (among other things) is currently being prepared.

The unit tests are passing with the latest stable WC version: https://github.com/woocommerce/google-listings-and-ads/actions/runs/9449506820/job/26027407446?pr=2426 The E2E tests are also passing, so based on these two tests I'll proceed with the release.

mikkamp commented 2 months ago

Original changelog notes:

What's Changed

[Add] New Features 🎉

New Contributors

Full Changelog: https://github.com/woocommerce/google-listings-and-ads/compare/2.7.1...2.7.2

eason9487 commented 2 months ago

Published updates for documentation: