search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
44 stars 21 forks source link

Add a query param `campaign=saved` to the dashboard URL when campaign was successfully created and saved #2442

Closed ianlin closed 2 months ago

ianlin commented 2 months ago

Changes proposed in this Pull Request:

Closes #2439.

This PR adds an extra query parameter campaign=saved to the dashboard URL to indicate that the campaign was successfully created and saved.

Screenshots:

Screenshot 2024-06-25 at 16 10 14

Detailed test instructions:

  1. Checkout the branch add/query-param-when-campaign-created
  2. Go to the dashboard page, click Add paid campaign, and create a campaign.
  3. After the campaign was created successfully, it will redirect back to the dashboard page.
  4. Confirm the URL contains a parameter campaign=saved.

Additional details:

Changelog entry

Add - Add an query parameter campaign=saved to the dashboard URL after the campaign was created

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.4%. Comparing base (466d34f) to head (4d50b73).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## develop #2442 +/- ## ============================================ - Coverage 64.3% 63.4% -0.9% ============================================ Files 780 321 -459 Lines 21910 5027 -16883 Branches 1218 1219 +1 ============================================ - Hits 14097 3188 -10909 + Misses 7646 1672 -5974 Partials 167 167 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.4% <66.7%> (ø)` | | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/utils/urls.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442?src=pr&el=tree&filepath=js%2Fsrc%2Futils%2Furls.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3V0aWxzL3VybHMuanM=) | `52.5% <100.0%> (ø)` | | | [js/src/pages/create-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fcreate-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2NyZWF0ZS1wYWlkLWFkcy1jYW1wYWlnbi9pbmRleC5qcw==) | `10.8% <0.0%> (ø)` | | ... and [459 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2442/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)