Closed jorgemd24 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.7%. Comparing base (
7ff8a9e
) to head (dc34f56
). Report is 1 commits behind head on feature/google-api-project.
Changes proposed in this Pull Request:
Part of #2146 .
Currently, we throw an exception if the request to revoke the token fails, such as when the WPCOM token is not found and therefore can't be deleted. This can lead to a fatal error when deactivating the plugin, preventing its deactivation. Since not all merchants will opt into the new mechanism, the scenario where the WPCOM token is missing is possible. To prevent this fatal error, I think it's better to catch the exception and log the error.
Additionally, I've removed the "Revoke WPCOM Access token" option from the Connection Test page. We now have a similar option, "WPCOM REST API Status" -> "Disconnect," which has the same purpose, making the option redundant.
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry