Closed jorgemd24 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.8%. Comparing base (
7ff8a9e
) to head (2171ce6
). Report is 36 commits behind head on feature/google-api-project.
I included the blog_id because I thought it might help with debugging issues, but I can't see it in Tracks. I'm not sure why that is.
@jorgemd24 I yes get the blog ID (in the logs using the snippets. In tracks I didn0't check)
Thanks @puntope for the review!
I yes get the blog ID (in the logs using the snippets. In tracks I didn0't check)
Yes, the blog_id
is being sent to Tracks, and it shows in the logs, but I can't see it in Tracks. I'll need to investigate further to see if there are any restrictions on sending this parameter to Tracks.
Can you take another look to this PR?
Hi @puntope,
I addressed your suggestions. Can u have another look? Thanks
Changes proposed in this Pull Request:
Part of #2146 .
Currently, we have two tracking events,
gla_disable_product_sync_click
andgla_enable_product_sync_click
. However, it would also be useful to track the status of the Auth flow and when merchants revoke access.This PR adds the following server-side event tracking:
revoke_wpcom_api_authorization
-> When the token is revoked, this event will include the status, blog id, and any error if it exists.update_wpcom_api_authorization
-> When the Auth flow is completed, this event will include the status, blog id, and any error if it exists.Screenshots:
Detailed test instructions:
wcadmin_gla_update_wpcom_api_authorization
andwcadmin_gla_revoke_wpcom_api_auth
. It may take some time for the data to appear.Ref: https://github.com/woocommerce/google-listings-and-ads/pull/2207
add_filter( 'woocommerce_gla_notifications_enabled','__return_true' )
;Disable product data fetch
:Additional details:
blog_id
because I thought it might help with debugging issues, but I can't see it in Tracks. I'm not sure why that is.Changelog entry