search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
44 stars 21 forks source link

[API PULL] Disable create and update notifications for variations #2464

Closed puntope closed 1 month ago

puntope commented 1 month ago

Changes proposed in this Pull Request:

Slack ref: p1720458122308169/1719561677.366209-slack-C02BB3F30TG

Detailed test instructions:

  1. Create a variable product
  2. Set the variables for the product and prices
  3. Publish the product
  4. See the Notification Create Job is scheduled for the parent. Run it
  5. Update the product description
  6. See the Notification Update Job is scheduled for the parent. Run it
  7. Update a variation price
  8. See the Notification Update Job is scheduled for the parent. Run it
  9. Delete a variation
  10. See the Notification Update Job is scheduled for the parent. Run it
  11. See in the logs the delete notification has been sent for the variable
  12. Set the parent product as "DONT SYNC AND SHOW"
  13. See the Notification Delete Job is scheduled for the parent and variations

Additional details:

Changelog entry

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.8%. Comparing base (e7be1ca) to head (0159630). Report is 47 commits behind head on feature/google-api-project.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/google-api-project #2464 +/- ## ============================================================ Coverage 64.8% 64.8% - Complexity 4561 4564 +3 ============================================================ Files 473 473 Lines 17799 17801 +2 ============================================================ + Hits 11533 11535 +2 Misses 6266 6266 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `64.8% <100.0%> (+<0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [src/Product/ProductHelper.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464?src=pr&el=tree&filepath=src%2FProduct%2FProductHelper.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL1Byb2R1Y3QvUHJvZHVjdEhlbHBlci5waHA=) | `92.2% <100.0%> (+0.1%)` | :arrow_up: | | [src/Product/SyncerHooks.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464?src=pr&el=tree&filepath=src%2FProduct%2FSyncerHooks.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL1Byb2R1Y3QvU3luY2VySG9va3MucGhw) | `90.0% <100.0%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2464/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)