woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
45 stars 21 forks source link

Update doc links references to google-for-woocommerce #2486

Closed puntope closed 1 month ago

puntope commented 1 month ago

Changes proposed in this Pull Request:

This PR replaces all the links pointing into https://woocommerce.com/document/google-listings-and-ads, https://woocommerce.com/document/google-for-woocommerce to

List of URLs Changed

https://woocommerce.com/document/google-listings-and-ads/#required-google-permissions (works in Old, anchor stop working in New) Its now a new page here. https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements ---- https://woocommerce.com/document/google-listings-and-ads/#contact-information (works in Old, anchor stop working in New) Updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#contact-information https://woocommerce.com/document/google-listings-and-ads/#general-requirements (works in Old, anchor stop working in New) ---- updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements https://woocommerce.com/document/google-listings-and-ads/#google-performance-max-campaigns (works in Old, anchor stop working in New) It's a new page now. https://woocommerce.com/document/google-for-woocommerce/get-started/google-performance-max-campaigns/ ---- https://woocommerce.com/document/google-listings-and-ads/#google-merchant-center-requirements (works in Old, anchor stop working in New) updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#google-merchant-center-requirements ---- https://woocommerce.com/document/google-listings-and-ads/#free-listings-on-google (works in Old, anchor stop working in New) New page is here. https://woocommerce.com/document/google-for-woocommerce/get-started/product-feed-information-and-free-listings/#section-1 ---- :warning: https://woocommerce.com/document/google-listings-and-ads/#getting-started-with-campaign-analytics (anchor doesn't work) Has a new page https://woocommerce.com/document/google-for-woocommerce/get-started/campaign-analytics/ ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/ (in new, it redirects to old) New page is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/ ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/#store-is-live (in new, it redirects to old) updated Link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#store-is-live ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/#complete-checkout (in new, it redirects to old) updated link is here https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#complete-checkout ---- :warning: https://woocommerce.com/document/google-for-woocommerce/compliance-policy/#refund-and-terms (in new, it redirects to old) updated link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#refund-and-terms ---- :warning: https://woocommerce.com/document/google-listings-and-ads-faqs New page is here. https://woocommerce.com/document/google-for-woocommerce/faq/

Detailed test instructions:

  1. Check that there are no links left to https://woocommerce.com/document/google-listings-and-ads
  2. Check that the links were replaced correctly and they work.

Additional details:

Changelog entry

Tweak - Update doc links references

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.6%. Comparing base (f398161) to head (679db10). Report is 15 commits behind head on develop.

Files Patch % Lines
src/MerchantCenter/MerchantStatuses.php 0.0% 1 Missing :warning:
src/Notes/SetupCampaign.php 0.0% 1 Missing :warning:
src/PluginHelper.php 0.0% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## develop #2486 +/- ## =========================================== + Coverage 64.5% 64.6% +0.1% - Complexity 4564 4575 +11 =========================================== Files 795 797 +2 Lines 22844 22898 +54 Branches 1220 1220 =========================================== + Hits 14739 14793 +54 Misses 7938 7938 Partials 167 167 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.5% <ø> (ø)` | | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `64.9% <0.0%> (+0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/components/help-icon-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fhelp-icon-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvaGVscC1pY29uLWJ1dHRvbi5qcw==) | `33.3% <ø> (ø)` | | | [src/MerchantCenter/MerchantStatuses.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?src=pr&el=tree&filepath=src%2FMerchantCenter%2FMerchantStatuses.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL01lcmNoYW50Q2VudGVyL01lcmNoYW50U3RhdHVzZXMucGhw) | `76.5% <0.0%> (ø)` | | | [src/Notes/SetupCampaign.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?src=pr&el=tree&filepath=src%2FNotes%2FSetupCampaign.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL05vdGVzL1NldHVwQ2FtcGFpZ24ucGhw) | `0.0% <0.0%> (ø)` | | | [src/PluginHelper.php](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486?src=pr&el=tree&filepath=src%2FPluginHelper.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-c3JjL1BsdWdpbkhlbHBlci5waHA=) | `82.9% <0.0%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
puntope commented 1 month ago

Thanks for the changes, I only found one location where we might want to change a link.

The rest are comments more related to the documentation itself, so we might need to follow up in a different location to get those changed. I also noticed that the breadcrumbs isn't very consistent:

image

image

I don't think we can change that in this PR so I will ping for updating the docs.