Closed puntope closed 1 month ago
Attention: Patch coverage is 0%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 64.6%. Comparing base (
f398161
) to head (679db10
). Report is 15 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
src/MerchantCenter/MerchantStatuses.php | 0.0% | 1 Missing :warning: |
src/Notes/SetupCampaign.php | 0.0% | 1 Missing :warning: |
src/PluginHelper.php | 0.0% | 1 Missing :warning: |
Thanks for the changes, I only found one location where we might want to change a link.
The rest are comments more related to the documentation itself, so we might need to follow up in a different location to get those changed. I also noticed that the breadcrumbs isn't very consistent:
I don't think we can change that in this PR so I will ping for updating the docs.
Changes proposed in this Pull Request:
This PR replaces all the links pointing into
https://woocommerce.com/document/google-listings-and-ads
,https://woocommerce.com/document/google-for-woocommerce
toList of URLs Changed
https://woocommerce.com/document/google-listings-and-ads/#required-google-permissions (works in Old, anchor stop working in New) Its now a new page here. https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements ---- https://woocommerce.com/document/google-listings-and-ads/#contact-information (works in Old, anchor stop working in New) Updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#contact-information https://woocommerce.com/document/google-listings-and-ads/#general-requirements (works in Old, anchor stop working in New) ---- updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements https://woocommerce.com/document/google-listings-and-ads/#google-performance-max-campaigns (works in Old, anchor stop working in New) It's a new page now. https://woocommerce.com/document/google-for-woocommerce/get-started/google-performance-max-campaigns/ ---- https://woocommerce.com/document/google-listings-and-ads/#google-merchant-center-requirements (works in Old, anchor stop working in New) updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#google-merchant-center-requirements ---- https://woocommerce.com/document/google-listings-and-ads/#free-listings-on-google (works in Old, anchor stop working in New) New page is here. https://woocommerce.com/document/google-for-woocommerce/get-started/product-feed-information-and-free-listings/#section-1 ---- :warning: https://woocommerce.com/document/google-listings-and-ads/#getting-started-with-campaign-analytics (anchor doesn't work) Has a new page https://woocommerce.com/document/google-for-woocommerce/get-started/campaign-analytics/ ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/ (in new, it redirects to old) New page is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/ ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/#store-is-live (in new, it redirects to old) updated Link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#store-is-live ---- :warning: https://woocommerce.com/document/google-listings-and-ads/compliance-policy/#complete-checkout (in new, it redirects to old) updated link is here https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#complete-checkout ---- :warning: https://woocommerce.com/document/google-for-woocommerce/compliance-policy/#refund-and-terms (in new, it redirects to old) updated link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#refund-and-terms ---- :warning: https://woocommerce.com/document/google-listings-and-ads-faqs New page is here. https://woocommerce.com/document/google-for-woocommerce/faq/
Detailed test instructions:
https://woocommerce.com/document/google-listings-and-ads
Additional details:
Changelog entry