woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
45 stars 21 forks source link

Update get started page #2498

Closed puntope closed 1 month ago

puntope commented 1 month ago

Changes proposed in this Pull Request:

This PR updates the top of getting started page to match the new content in https://woocommerce.com/products/google-listings-and-ads/

Screenshots:

Implementation in app

Screenshot 2024-08-06 at 19 56 35 Screenshot 2024-08-06 at 19 56 44

Recommendations

Screenshot 2024-08-06 at 19 57 01 Screenshot 2024-08-06 at 19 56 57

Detailed test instructions:

  1. Checkout PR and verify the changes look as the recommendations in the screenshots provided.

Additional details:

Changelog entry

Tweak - Update get started page

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.5%. Comparing base (a8e9cac) to head (70f569d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## develop #2498 +/- ## ============================================ - Coverage 64.7% 63.5% -1.1% ============================================ Files 797 322 -475 Lines 22930 5043 -17887 Branches 1220 1220 ============================================ - Hits 14825 3204 -11621 + Misses 7938 1672 -6266 Partials 167 167 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `63.5% <ø> (ø)` | | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. [see 475 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2498/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
puntope commented 1 month ago

However, I'm guessing that is intended so the changes look good to me.

Thx @martynmjones for that point. I will ask and if so. I will update it in further PR