Open joemcgill opened 1 month ago
This includes removing and cleaning up the
clientSession
helper injs/src/setup-mc/setup-stepper/setup-paid-ads/clientSession.js
that is also referenced in thePaidAdsSetupSections
component.
Does it mean the uses of clientSession.getCampaign()
and clientSession.setCampaign( nextPaidAds )
are planned to remove?
Does it mean the uses of clientSession.getCampaign() and clientSession.setCampaign( nextPaidAds ) are planned to remove?
No, I don't think there is any reason to remove those methods. We should just remove the clientSession.setShowPaidAdsSetup
and clientSession.getShowPaidAdsSetup
methods. I'll clarify in the Implementation Brief. Thanks!
Engineering complete and approved, moving to UAT for @fblascogarma final approval
Just tagging @joemcgill and @asvinb to advise this needs to be merged please
Merge conflicts fixed and assigning to @fblascogarma for final approval.
Part of https://github.com/woocommerce/google-listings-and-ads/issues/2459
Currently, the first time someone gets to the Create a Campaign step of the onboarding flow, they are presented with a promotion for PMax campaigns with the option either skip or create a campaign. Choosing to Create a Campaign reveals the forms fields needed to set up your first campaign. This adds unnecessary friction since this step is much simpler than it was when originally introduced.
Instead of showing the Skip/Create buttons in the
PaidAdsFeaturesSection
and hidingPaidAdsSetupSections
components, we will always show thePaidAdsSetupSections
.Acceptance Criteria
When reaching the Create a Campaign step of the onboarding flow:
PaidAdsSetupSections
) no longer show footer buttons.PaidAdsSetupSections
) are always visible.SetupPaidAds
components.Implementation Brief
Whether the footer buttons are shown in the
PaidAdsFeaturesSection
or not is based on thehideFooterButtons
prop of that component, which currently passes! hasGoogleAdsConnection || showPaidAdsSetup
. This entire prop can be removed and the footer buttons removed from the component itself and all the related logic be removed fromjs/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js
where this component is being used.Likewise, the
PaidAdsSetupSections
andStepContentFooter
are only shown ifshowPaidAdsSetup
is true. Now that we always want to show that component, we can remove all the logic related toshowPaidAdsSetup
, which is set via auseState()
hook. This includes removing remove theclientSession.setShowPaidAdsSetup
andclientSession.getShowPaidAdsSetup
methods injs/src/setup-mc/setup-stepper/setup-paid-ads/clientSession.js
. The rest of that file should remain since it is also referenced by thePaidAdsSetupSections
component.Test Coverage
Update E2E tests in tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js to match expected behavior and remove unused helpers.