Open joemcgill opened 2 months ago
- Are there any side effects that we would need to be aware of when using target audience data from MC for the Ads campaign?
I think there shouldn't be any side effects because the target audiences from MC are originally the default value when the starting campaign creation.
There is a code conflict so I moved this ticket to the In Progress status. I believe the PR won't need another round of code reviews after resolving the code conflict.
Thanks @eason9487 . Merge conflicts fixed. As per your comment, assigning task to @fblascogarma for UAT.
Part of https://github.com/woocommerce/google-listings-and-ads/issues/2459
Today we show “Ads audience” (see screenshot below) but instead, we can remove it and target all countries selected during product feed configuration (step 2).
Acceptance Criteria
Implementation Brief
The
AudienceSection
component can be removed from thePaidAdsSetupSections
component. Update thePaidAdsSetupSections
component so that it initializes thepaidAds
state with targetAudience data that was saved in step 2. We can probably use thegetTargetAudience
selector to get this data, but will need to make sure that it then gets formatted in a way that is expected when the form is submitted.Test Coverage
Update the E2E tests for
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
to remove tests related to the audience field.