woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
45 stars 21 forks source link

Upgrade to use Node.js 20 and bump npm dependencies #2517

Closed eason9487 closed 3 weeks ago

eason9487 commented 1 month ago

Changes proposed in this Pull Request:

Closes #2002

This PR:

❗ Since the jest testing requires a lot of adjustments, it will be handled by #2544. Two of the eslint rule errors are highly related to jest and are therefore handled by #2544 as well.

Detailed test instructions:

  1. Set Node.js to v20
  2. Run npm install to see if it can finish without errors
  3. Check if the following scripts work well
    • npm run build
    • npm run dev
    • npm run start
    • npm run start:hot
    • npm run lint:css
    • npm run lint:js
      • There are two pre-existing warnings that still can not be fixed after this upgrade
      • Errors from the testing-library/no-unnecessary-act and testing-library/no-unnecessary-act rules are handled separately in #2544
  4. Run node ./node_modules/.bin/bundlewatch to check if the check works
  5. Do some smoke testing

Changelog entry

Dev - Upgrade to use Node.js 20 and bump npm dependencies.

puntope commented 3 weeks ago

Address Sass deprecation warnings.

I still see the deprecations in both this PR and in https://github.com/woocommerce/google-listings-and-ads/pull/2544

Screenshot 2024-08-21 at 14 04 13
eason9487 commented 3 weeks ago

Hi @puntope

I still see the deprecations in both this PR and in #2544

The SCSS styles that caused deprecations came from @wordpress/base-styles and could not be resolved from this repo.

eason9487 commented 3 weeks ago

Hi @puntope, thanks for the review! This PR is ready for a new round of code reviews.