Closed eason9487 closed 3 weeks ago
Address Sass deprecation warnings.
I still see the deprecations in both this PR and in https://github.com/woocommerce/google-listings-and-ads/pull/2544
Hi @puntope
I still see the deprecations in both this PR and in #2544
The SCSS styles that caused deprecations came from @wordpress/base-styles
and could not be resolved from this repo.
Hi @puntope, thanks for the review! This PR is ready for a new round of code reviews.
Changes proposed in this Pull Request:
Closes #2002
This PR:
react/react-in-jsx-scope
rulejsdoc/check-line-alignment
ruleimport/no-named-as-default
rulenpm run lint:js -- --fix
: c41ef64@wordpress/i18n-text-domain
rule: cdd9aabjsdoc/no-undefined-types
rule: 67ef0e2import/no-unresolved
rule: c4db2a3no-redeclare
rule: 6997b6fjsdoc/require-yields-check
rule: 47d1f9f@typescript-eslint/no-use-before-define
rule: 9886344jsdoc/tag-lines
rule: fccc0cd❗ Since the jest testing requires a lot of adjustments, it will be handled by #2544. Two of the eslint rule errors are highly related to jest and are therefore handled by #2544 as well.
Detailed test instructions:
npm install
to see if it can finish without errorsnpm run build
npm run dev
npm run start
npm run start:hot
npm run lint:css
npm run lint:js
testing-library/no-unnecessary-act
andtesting-library/no-unnecessary-act
rules are handled separately in #2544node ./node_modules/.bin/bundlewatch
to check if the check worksChangelog entry